The product has multiple functions, methods, procedures, macros, etc. that contain the same code.
This issue makes it more difficult to maintain the product, which indirectly affects security by making it more difficult or time-consuming to find and/or fix vulnerabilities. For example, if there are two copies of the same code, the programmer might fix a weakness in one copy while forgetting to fix the same weakness in another copy.
Threat Mapped score: 0.0
Industry: Finiancial
Threat priority: Unclassified
N/A
N/A
| Phase | Note |
|---|---|
| None listed. | |
Intro: In the following Java example the code performs some complex math when specific test conditions are met. The math is the same in each case and the equations are repeated within the code. Unfortunately if a future change needs to be made then that change needs to be made in all locations. This opens the door to mistakes being made and the changes not being made in the same way in each instance.
Body: It is recommended to place the complex math into its own function and then call that function whenever necessary.
public class Main { public static void main(String[] args) { double s = 10.0; double r = 1.0; double pi = 3.14159; double surface_area; if(r > 0.0) { // complex math equations surface_area = pi * r * s + pi * Math.pow(r, 2); } if(r > 1.0) { // a complex set of math surface_area = pi * r * s + pi * Math.pow(r, 2); } } }